Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for node runtime and import from node buffer for Blob #225

Merged
merged 3 commits into from
Oct 3, 2023
Merged

add check for node runtime and import from node buffer for Blob #225

merged 3 commits into from
Oct 3, 2023

Conversation

joshLong145
Copy link

fixes an observed issue with encryptWithSymmetricKey which throws an error in NodeJS when attempting to use the Blob object as it is not available in global scope.

refactors to check for if the env is node and then imports node:buffer to use the compatible Blob object

@joshLong145
Copy link
Author

joshLong145 commented Oct 2, 2023 •
edited
Loading

Link to ticket: https://linear.app/litprotocol/issue/LIT-1548/sdkv2-encryption-not-working-in-the-nodejs-sdk

DashKash54
DashKash54 previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@DashKash54 DashKash54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshLong145 joshLong145 requested a review from DashKash54 October 3, 2023 17:29
@joshLong145 joshLong145 merged commit 7036eb7 into master Oct 3, 2023
@joshLong145 joshLong145 deleted the fix/encrypt-with-sym-key-nodejs branch October 3, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ansonhkg Ansonhkg Awaiting requested review from Ansonhkg Ansonhkg is a code owner

@DashKash54 DashKash54 Awaiting requested review from DashKash54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshLong145 @DashKash54