Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rubocop, brakeman, bundler-audit #236

Merged
merged 13 commits into from
Jan 29, 2024
Merged

Conversation

syl-p
Copy link
Collaborator

@syl-p syl-p commented Dec 1, 2023

No description provided.

@syl-p syl-p marked this pull request as ready for review December 1, 2023 14:26
@syl-p syl-p requested a review from brunto December 1, 2023 14:31
@syl-p syl-p force-pushed the add-rubocop-to-project branch 2 times, most recently from 035843e to 2da4eb2 Compare December 4, 2023 09:08
@syl-p syl-p changed the title chore: add rubocop gem to gemfile Add Rubocop, brakeman, bundler-audit Dec 4, 2023
@brunto
Copy link
Collaborator

brunto commented Dec 18, 2023

@syl-p LINT to fix

@syl-p syl-p force-pushed the add-rubocop-to-project branch from 432e7c8 to c84d3a7 Compare January 2, 2024 15:50
@brunto brunto force-pushed the add-rubocop-to-project branch from c84d3a7 to 4be0e08 Compare January 24, 2024 12:22
Three old Rails default framework files (5.2, 6.0, 7.0) have been deleted. The Rails default version has been upgraded from 5.0 to 7.0 in the application configuration. Various modifications have also been made across the test files to consistently use FactoryBot for object creation.
Added the nokogiri dependency for the x86_64-linux platform in the Gemfile.lock. This update ensures that the application will run smoothly on both the arm64-darwin-23 and the newly added x86_64-linux platforms.
Environment variables `RAILS_ENV` and `DATABASE_URL` are now set earlier in the GitHub Actions workflow. This change provides better organization and makes sure that necessary variables are set before running the subsequent tasks.
brunto
brunto previously approved these changes Jan 24, 2024
@brunto brunto requested a review from kevin-atnos January 24, 2024 13:14
kevin-atnos
kevin-atnos previously approved these changes Jan 24, 2024
The versions of Ruby and Bundler used in the project have been updated. Our Ruby version has been updated from 3.1.4p223 to 3.3.0p0 and Bundler is now set to 2.5.3. This will ensure compatibility with the latest updates and features.
@kevin-atnos kevin-atnos dismissed stale reviews from brunto and themself via 9a14a5a January 24, 2024 16:06
@kevin-atnos kevin-atnos mentioned this pull request Jan 24, 2024
@kevin-atnos
Copy link
Collaborator

kevin-atnos commented Jan 24, 2024

Note :

  • À retester en local avant de merger.

@brunto brunto requested review from kevin-atnos and brunto January 25, 2024 09:23
@kevin-atnos kevin-atnos merged commit 0b51cdd into master Jan 29, 2024
4 checks passed
@brunto brunto deleted the add-rubocop-to-project branch January 29, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants