Remove numbering feature and add unchecked constructors #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfaster
suggested changes
Jul 24, 2023
This fixes the unsound Graph::new and Mesh::new. See the following report for more details: <#11> Co-authored-by: Gavin Rohrer <[email protected]>
hhirtz
force-pushed
the
fix-unsound
branch
2 times, most recently
from
41a1d76
to
a252594
Compare
# Conflicts: # src/lib.rs # src/option.rs
cedricchevalier19
force-pushed
the
fix-unsound
branch
from
2e25a8d
to
e3e8664
Compare
cedricchevalier19
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
TODO
mesh_to_dual