Airmass / Altitude boundary display in skymap #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good!
W
…On Tue, Oct 1, 2024 at 6:37 PM Tim Beccue ***@***.***> wrote:
This change adds a feature to the skymap requested by Wayne: a yellow
circle at a specific altitude or airmass that can be configured.
Screenshot.2024-10-01.at.2.26.39.PM.png (view on web)
<https://github.com/user-attachments/assets/bd8b475b-9cd0-4111-b64b-edc6c165cb2e>
The value of altitude or airmass that is displayed can be set by the user
Screenshot.2024-10-01.at.2.27.34.PM.png (view on web)
<https://github.com/user-attachments/assets/75339b68-5747-4be4-9c6d-83ddb16bd599>
Screenshot.2024-10-01.at.2.27.17.PM.png (view on web)
<https://github.com/user-attachments/assets/33976323-5c4d-4d30-b46f-d56cec226af8>
This input component will automatically convert between the two to keep
the same circle across changes in units. For example, if the user has "2"
entered with airmass selected and they change the units to altitude, the
input will update to "30" and the yellow circle won't change. This
conversion becomes less accurate at the extremes.
Hovering over the yellow circle will display a label showing the altitude
at the bottom of the circle.
Screenshot.2024-10-01.at.2.32.06.PM.png (view on web)
<https://github.com/user-attachments/assets/d3bea0ee-e7ec-4c0f-8602-e944cc4b038c>
------------------------------
You can view, comment on, or merge this pull request online at:
#163
Commit Summary
- 1f40650
<1f40650>
Add configurable circle showing airmass limit on sky chart
- 97b69d4
<97b69d4>
Improve error messages and conversion precision
- 8f9f10d
<8f9f10d>
Show label on hover
- e5487eb
<e5487eb>
Update labels
File Changes
(4 files <https://github.com/LCOGT/ptr_ui/pull/163/files>)
- *A* src/components/FormElements/AirmassAltitudeInput.vue
<https://github.com/LCOGT/ptr_ui/pull/163/files#diff-2c043d8b6ef9652ade0ea4305e75f6ebd0be7cd8ef7f447b575126550b03410f>
(140)
- *M* src/components/celestialmap/TheSkyChart.vue
<https://github.com/LCOGT/ptr_ui/pull/163/files#diff-0e51f7401dd23f966d72940474ae62f0f061135bc10555c267536f493ea504aa>
(44)
- *M* src/components/celestialmap/add_custom_data.js
<https://github.com/LCOGT/ptr_ui/pull/163/files#diff-bc923bdd07c8e3e2e9be079461d82b25a5faec8a69de0c9d0f008cd8a2646a6f>
(49)
- *M* src/components/sitepages/SiteTargets.vue
<https://github.com/LCOGT/ptr_ui/pull/163/files#diff-c992c75f428b5765296f1101232ae64314c35c57aeeb9b08d33351e97964389d>
(69)
Patch Links:
- https://github.com/LCOGT/ptr_ui/pull/163.patch
- https://github.com/LCOGT/ptr_ui/pull/163.diff
—
Reply to this email directly, view it on GitHub
<#163>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTZ3MB7DI5RCRFXNXYCLLTZZLTXRAVCNFSM6AAAAABPGFNB5GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TSOJTG43TENQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a feature to the skymap requested by Wayne: a yellow circle at a specific altitude or airmass that can be configured.
The value of altitude or airmass that is displayed can be set by the user
This input component will automatically convert between the two to keep the same circle across changes in units. For example, if the user has "2" entered with airmass selected and they change the units to altitude, the input will update to "30" and the yellow circle won't change. This conversion becomes less accurate at the extremes.
Hovering over the yellow circle will display a label showing the altitude at the bottom of the circle.
