Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aladin view #160

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Fix/aladin view #160

merged 6 commits into from
Jul 2, 2024

Conversation

capetillo
Copy link
Contributor

FIX AND REARRANGEMENTS: Aladin view

Background:
Wayne requested to change a few aspects of the Aladin section under the Sky Map tab. His requests included: 1. removing search for object under Aladin 2. removing the slew to RA/DEC and slew & center buttons 3. rearrange the order of the boxes in the accordion 4. when searching for an object, automatically populate the Hour Angle, Azimuth, and Altitude

Implementation:
I got rid of the unwanted components and rearranged as needed. For the last request this is what I did:
In the helpers.js file I corrected eq2altaz by converting ha (hour angle) to degrees. With this function, we can get azimuth and altitude.
Then, I added eq2hourangle function to return hour angle in hours.
Then these two helper functions are used in handle_coordinate_search_results in the Telescope component.

VISUALS

Before-- you can see that after searching for an object, hour angle, azimuth, and altitude remain blank
Screenshot 2024-07-02 at 3 10 50 PM

After-- fields are automatically filled out :)
Screenshot 2024-07-02 at 3 12 35 PM

@capetillo capetillo requested review from mgdaily and LTDakin July 2, 2024 22:13
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!!!

@capetillo capetillo merged commit e6583c5 into dev Jul 2, 2024
1 check passed
@capetillo capetillo deleted the fix/aladin-view branch July 2, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants