Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX AND REARRANGEMENTS: Aladin view
Background:
Wayne requested to change a few aspects of the Aladin section under the
Sky Map
tab. His requests included: 1. removing search for object under Aladin 2. removing theslew to RA/DEC
andslew & center
buttons 3. rearrange the order of the boxes in the accordion 4. when searching for an object, automatically populate theHour Angle
,Azimuth
, andAltitude
Implementation:
I got rid of the unwanted components and rearranged as needed. For the last request this is what I did:
In the
helpers.js
file I correctedeq2altaz
by convertingha
(hour angle) to degrees. With this function, we can getazimuth
andaltitude
.Then, I added
eq2hourangle
function to return hour angle in hours.Then these two helper functions are used in
handle_coordinate_search_results
in theTelescope
component.VISUALS
Before-- you can see that after searching for an object, hour angle, azimuth, and altitude remain blank
After-- fields are automatically filled out :)