changed a of rgba, changed width of bar, and moved z-index of weather… #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUICK UI FIX: Width and opacity of lunar band and position of weather band
Background:
Wayne requested the lunar band to be a tad wider and more opaque and to have the weather band on top of the lunar band.
Implementation:
The function
rgba_from_illuminationdetermines the color and the alpha (i.e. opacity) of the moon band. The alpha was too low so I added1to it to make it more opaque. I changed the width of the moon to be20px. And uncommented this linez-index: $forecast-z-index !importantto bring the weather band on top of the lunar bandVISUALS:
Before
After
