Feature/project requests #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE: Some project requests
Background:
Wayne made some requests here to change and add some of the advanced options in the Projects tab.
Implementation
For the first request, it was quite simple to change the default.
The second request followed the implementation of
min_zenith_dist. So I added it to the store, added a getter, added a mutation, and added an action inproject_params. I set the default value to 6 hours, the min to 0, the max to 24, and the step of 0.5. That's it!The last request just required moving the existing field elsewhere. No logic changed
Visuals
Screenshot of the project form with updated requests
Screen recording of the store updating the new state of
max night durationScreen.Recording.2024-02-21.at.4.05.07.PM.mov