Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fixes for Create Project #142

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

LTDakin
Copy link
Contributor

@LTDakin LTDakin commented Feb 2, 2024

Micheal mentioned that projects could be created without a target name. This PR fixes that as well as a lot of other bugs I found along the way which include: hanging on empty search, no error messages for missing ra and dec, and not verifying fields when modifying a project

Changes

  • new field 'Name' splitting up the functionality of the Object Search field.
  • check for target name in verifyForm() so that a target name is required to create or modify a project
  • warning messages for missing ra and dec fields
  • error message for unknown targets are now info instead of an error

Fixes

  • fixed naming for projectRa and projectDec to targetRa and targetDec
  • added a VerifyForm call to modifyProject, previously it was missing
  • removed unnecessary b-field tag
  • removed redundant logic for checking ra and dec fields are empty in verifyForm()
  • combined two separate checks for warnings into one if/else
  • check for if result.Target exists to prevent hanging on an blank target search

Screenshot 2024-02-06 at 12 04 29 PM

Copy link
Contributor

@capetillo capetillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment : )

@LTDakin LTDakin merged commit 01eb923 into dev Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants