Draw sublunar point on ptr world map #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently using a questionable algorithim
capetillo
previously approved these changes
Jan 9, 2024
capetillo
reviewed
Jan 9, 2024
markBowman
reviewed
Jan 10, 2024
markBowman
reviewed
Jan 10, 2024
| const normalizedM = rev(M + 129 * 360); | ||
|
|
||
| // Compute eccentric anomaly (E) | ||
| let E0 = normalizedM + (180 / Math.PI) * e * Math.sin(normalizedM) * (1 + e * Math.cos(normalizedM)); |
There was a problem hiding this comment.
I thought javascript Math.sin() etc used radians rather than degrees
markBowman
reviewed
Jan 10, 2024
markBowman
reviewed
Jan 10, 2024
| const E = E1; | ||
|
|
||
| // Rectangular coordinates in the plane of the lunar orbit | ||
| const x = a * (Math.cos(degToRad * E) - e); |
There was a problem hiding this comment.
Yeah, this looks right - converting degrees to radians before taking the cosine
markBowman
reviewed
Jan 10, 2024
|
Ah I see why it's not working. This formula gives ecliptic longitude and latitude when I need to get earth coordinates. Will look for a formula for that or ask Tim again. |
LTDakin
dismissed
capetillo’s stale review
it dont work, also I've never clicked this button so want to see what it does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draws the moon to the world map on the ptr home screen
using an good enough equation supplied by Tim Lister -> https://stjarnhimlen.se/comp/tutorial.html#7.
Tested against this website to check accuracy -> https://www.timeanddate.com/worldclock/sunearth.php
Hard to test since I don't understand the math too much, so will keep an eye on it for a week to make sure it stays accurate and no errors come up.