Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/camera zoom #136

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Fix/camera zoom #136

merged 5 commits into from
Dec 22, 2023

Conversation

capetillo
Copy link
Contributor

@capetillo capetillo commented Dec 22, 2023

FIX: NOW PASSING ZOOM TO OPT_PARAMS

DESCRIPTION:

Background:

Wayne pointed out that the zoom values under the Camera tab were not being passed to opt_params. He also requested to change some of the values from % to magnification. Two birds, one stone.

Implementation:

Quick fix, just imported zoom_options_selection from command_params into command_mixin and under opt_params I passed zoom: this.zoom_options_selection.
For the latter request, I just changed the values in the array.

VISUALS:

You can see in the console that there's now a zoom value
Screenshot 2023-12-22 at 11 24 40 AM

And it updates when a different selection is chosen
Screenshot 2023-12-22 at 11 24 47 AM

…se it was giving errors. unrelated to the fix im trying to make. and changed the key to the filter rather than the index
Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused what is interpretting the zoom values (1.5x, 2x, etc.)... Is that being passed down to Wayne's site code which is expecting those new values?

@capetillo
Copy link
Contributor Author

@jnation3406 I don't know why I can't reply to your comment, but to answer your question: yes. Matt asked Wayne a couple of days ago and granted I don't understand the engineering of telescopes, it sounded like the sitecode was taking care of it

@capetillo capetillo merged commit 714ef51 into dev Dec 22, 2023
1 check passed
@capetillo capetillo deleted the fix/camera-zoom branch December 22, 2023 20:09
@wrosing
Copy link

wrosing commented Dec 22, 2023 via email

@wrosing
Copy link

wrosing commented Dec 22, 2023 via email

@wrosing
Copy link

wrosing commented Dec 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants