-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/camera zoom #136
Fix/camera zoom #136
Conversation
…se it was giving errors. unrelated to the fix im trying to make. and changed the key to the filter rather than the index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused what is interpretting the zoom values (1.5x, 2x, etc.)... Is that being passed down to Wayne's site code which is expecting those new values?
@jnation3406 I don't know why I can't reply to your comment, but to answer your question: yes. Matt asked Wayne a couple of days ago and granted I don't understand the engineering of telescopes, it sounded like the sitecode was taking care of it |
Please restart dev at a convenient point so I can verify the latest
fix/change.
W
…On Fri, Dec 22, 2023 at 8:09 PM Carolina Capetillo ***@***.***> wrote:
Merged #136 <#136> into dev.
—
Reply to this email directly, view it on GitHub
<#136 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTZ3MHETCACIY4F4BTKDLDYKXSH7AVCNFSM6AAAAABBAGAHWWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZDSMJZGEYDMNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
|
I guess restart the PTR web server, not dev...W
…On Fri, Dec 22, 2023 at 8:52 PM Wayne Rosing ***@***.***> wrote:
Please restart dev at a convenient point so I can verify the latest
fix/change.
W
On Fri, Dec 22, 2023 at 8:09 PM Carolina Capetillo <
***@***.***> wrote:
> Merged #136 <#136> into dev.
>
> —
> Reply to this email directly, view it on GitHub
> <#136 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACTZ3MHETCACIY4F4BTKDLDYKXSH7AVCNFSM6AAAAABBAGAHWWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZDSMJZGEYDMNI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
|
Looks like this just happened, thanks. Will test now.
…On Fri, Dec 22, 2023 at 8:53 PM Wayne Rosing ***@***.***> wrote:
I guess restart the PTR web server, not dev...W
On Fri, Dec 22, 2023 at 8:52 PM Wayne Rosing ***@***.***> wrote:
> Please restart dev at a convenient point so I can verify the latest
> fix/change.
> W
>
> On Fri, Dec 22, 2023 at 8:09 PM Carolina Capetillo <
> ***@***.***> wrote:
>
>> Merged #136 <#136> into dev.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#136 (comment)>, or
>> unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ACTZ3MHETCACIY4F4BTKDLDYKXSH7AVCNFSM6AAAAABBAGAHWWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGMZDSMJZGEYDMNI>
>> .
>> You are receiving this because you are subscribed to this thread.Message
>> ID: ***@***.***>
>>
>
>
> --
> Clear skies,
>
> Wayne Rosing
> Founder
> 805 452 3229 cell <<<NEW! Please do not give out widely.
> 805 880 1603 office
>
> Please note ***@***.*** is our preferred address.
>
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
--
Clear skies,
Wayne Rosing
Founder
805 452 3229 cell <<<NEW! Please do not give out widely.
805 880 1603 office
Please note ***@***.*** is our preferred address.
|
FIX: NOW PASSING ZOOM TO OPT_PARAMS
DESCRIPTION:
Background:
Wayne pointed out that the
zoom
values under theCamera
tab were not being passed toopt_params
. He also requested to change some of the values from % to magnification. Two birds, one stone.Implementation:
Quick fix, just imported
zoom_options_selection
fromcommand_params
intocommand_mixin
and underopt_params
I passedzoom: this.zoom_options_selection
.For the latter request, I just changed the values in the array.
VISUALS:
You can see in the console that there's now a
zoom
valueAnd it updates when a different selection is chosen