removed observing side replace with ascending, descending #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the state variable observing_side from project_params, instead to support the selection of both ascending and descending the field was replaced with two checkboxes and the state was replaced with two new states 'ascending' and 'descending' that will be sent to site code instead
After consulting with Wayne default behavior for these values should be true for both of them. Changing the state default to reflect this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request: Allow both ascending and descending to be selected instead of just one or the other
Previously we had a state variable called observing_side that could only be ascending OR descending. But some observations would like to follow a target as its ascending and then switch to continue following while descending. To do this we need to allow for both options to be selected independently.
Default behavior will be true for both values
replaced the state variable observing_side from project_params, instead to support the selection of both ascending and descending the field was replaced with two checkboxes and the state was replaced with two new states 'ascending' and 'descending' that will be sent to site code instead