Update/observe page UI changes #122
Conversation
Moved telescope controls that were previously at the top of the observe tab to a new tab next to controls named telescope. Also commented out leader follower options from the ui at wayne's request
…erve-page-ui-changes
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
src/components/sitepages/SiteData.vue|119 col 26| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|124 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|124 col 27| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|128 col 47| Expected 1 line break after opening tag (<div>), but no line breaks found.
src/components/sitepages/SiteData.vue|128 col 61| Expected 1 line break before closing tag (</div>), but no line breaks found.
src/components/sitepages/SiteData.vue|129 col 69| 'style' should be on a new line.
src/components/sitepages/SiteData.vue|129 col 89| Expected a space before '/>', but not found.
src/components/sitepages/SiteData.vue|135 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|135 col 26| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|140 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|140 col 27| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|145 col 47| Expected 1 line break after opening tag (<div>), but no line breaks found.
src/components/sitepages/SiteData.vue|145 col 65| Expected 1 line break before closing tag (</div>), but no line breaks found.
src/components/sitepages/SiteData.vue|146 col 62| 'style' should be on a new line.
src/components/sitepages/SiteData.vue|146 col 82| Expected a space before '/>', but not found.
src/components/sitepages/SiteData.vue|152 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|152 col 25| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|157 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|157 col 24| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|162 col 47| Expected 1 line break after opening tag (<div>), but no line breaks found.
src/components/sitepages/SiteData.vue|162 col 62| Expected 1 line break before closing tag (</div>), but no line breaks found.
src/components/sitepages/SiteData.vue|163 col 66| 'style' should be on a new line.
src/components/sitepages/SiteData.vue|163 col 86| Expected a space before '/>', but not found.
src/components/sitepages/SiteData.vue|169 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|169 col 25| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|174 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|174 col 26| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|179 col 47| Expected 1 line break after opening tag (<div>), but no line breaks found.
src/components/sitepages/SiteData.vue|179 col 65| Expected 1 line break before closing tag (</div>), but no line breaks found.
src/components/sitepages/SiteData.vue|180 col 61| 'style' should be on a new line.
src/components/sitepages/SiteData.vue|180 col 81| Expected a space before '/>', but not found.
src/components/sitepages/SiteData.vue|186 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|186 col 26| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
src/components/sitepages/SiteData.vue|191 col 20| Expected 1 line break after opening tag (<CommandButton>), but no line breaks found.
src/components/sitepages/SiteData.vue|191 col 27| Expected 1 line break before closing tag (</commandbutton>), but no line breaks found.
moved the check for userIsAdmin to the tab itself so the whole tab will not show up unless you are an admin, before this change it would have the telescope tab but it would be empty inside. This way is more logical
Wayne originally wanted it to be named telescope config, also there is a telescope tab underneath controls so this helps add some distinction
Wayne's UI request: move the telescope options to their own tab and to comment out leader follower buttons
Moved the options that form the block of controls ranging from manual telescope to pointing reference to a tab located next to controls named "Telescope Config"
In addition commented out the Leader and Follower tabs
As you can see below the config for telescope that was previously on top is now on its own tab that is only visible when you are an admin or owner
BEFORE:
AFTER:
