Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update analysis functions to work on ocs archived fits images #113

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Update analysis functions to work on ocs archived fits images #113

merged 3 commits into from
Oct 30, 2023

Conversation

jnation3406
Copy link
Contributor

This won't work until the photonranch-api change is merged, but its safe to deploy before then.

github-actions[bot]
github-actions bot reviewed Oct 21, 2023
View reviewed changes
src/components/AnalysisTools/HistogramTool.vue Outdated
@@ -6,7 +6,7 @@
title="Get histogram from the selected rectangle region."
class="button"
:class="{ 'is-loading': region_histogram_loading }"
:disabled="!large_fits_exists && !small_fits_exists"
:disabled="!this.current_image.fits_filename"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <vue/this-in-template> reported by reviewdog 🐶
Unexpected usage of 'this'.

Suggested change
:disabled="!this.current_image.fits_filename"
:disabled="!current_image.fits_filename"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnation3406 are these red herrings? I don't believe this works in templates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does work in templates, but its a stylistic thing. I'm happy to remove them.

src/components/AnalysisTools/HistogramTool.vue Outdated
@@ -16,7 +16,7 @@
<button
class="button"
:class="{ 'is-loading': image_histogram_loading }"
:disabled="!large_fits_exists && !small_fits_exists"
:disabled="!this.current_image.fits_filename"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <vue/this-in-template> reported by reviewdog 🐶
Unexpected usage of 'this'.

Suggested change
:disabled="!this.current_image.fits_filename"
:disabled="!current_image.fits_filename"

src/components/AnalysisTools/ImageStatisticsViewer.vue Outdated
@@ -6,7 +6,7 @@
title="Only inspect the selected rectangle region."
class="button"
:class="{'is-loading':region_stats_loading}"
:disabled="!large_fits_exists && !small_fits_exists"
:disabled="!this.current_image.fits_filename"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <vue/this-in-template> reported by reviewdog 🐶
Unexpected usage of 'this'.

Suggested change
:disabled="!this.current_image.fits_filename"
:disabled="!current_image.fits_filename"

src/components/AnalysisTools/ImageStatisticsViewer.vue Outdated
@@ -16,7 +16,7 @@
<button
class="button"
:class="{'is-loading':image_stats_loading}"
:disabled="!large_fits_exists && !small_fits_exists"
:disabled="!this.current_image.fits_filename"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <vue/this-in-template> reported by reviewdog 🐶
Unexpected usage of 'this'.

Suggested change
:disabled="!this.current_image.fits_filename"
:disabled="!current_image.fits_filename"

src/components/AnalysisTools/LineProfileInspection.vue Outdated
title="first draw a line on the image to inspect"
class="button"
:class="{'is-loading': analysisInProgress}"
:disabled="!this.current_image.fits_filename"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <vue/this-in-template> reported by reviewdog 🐶
Unexpected usage of 'this'.

Suggested change
:disabled="!this.current_image.fits_filename"
:disabled="!current_image.fits_filename"

mgdaily
mgdaily approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a question about the eslint checks

src/components/AnalysisTools/HistogramTool.vue Outdated
@@ -6,7 +6,7 @@
title="Get histogram from the selected rectangle region."
class="button"
:class="{ 'is-loading': region_histogram_loading }"
:disabled="!large_fits_exists && !small_fits_exists"
:disabled="!this.current_image.fits_filename"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnation3406 are these red herrings? I don't believe this works in templates?

@jnation3406 jnation3406 merged commit 5fd0ee0 into dev Oct 30, 2023
1 check passed
@jnation3406 jnation3406 deleted the fix/quickanalysis_source branch October 30, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mgdaily mgdaily mgdaily approved these changes

@capetillo capetillo Awaiting requested review from capetillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnation3406 @mgdaily