Feature/owm report mirrored #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osure tabs TODO: Still need to cache the value in the vuex store for an hour max, and fetch it if it exists. Also conditionally render OWM report on home tab based on whether user is admin
…m-report-mirrored
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mgdaily
requested changes
Oct 18, 2023
mgdaily
requested changes
Oct 19, 2023
These changes should be in a seperate PR instead of this one. TODO: create a seperate pr to address this bug
mgdaily
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Users wanted to see OWM reports on the home tab of site pages.
Solution:
Created a component out of the OWMReport data and copied it over to the home tab.
Carried over property of the data only being visible to Admins.
In addition improved performance of app by changing the behavior of the OwmReport. Previously it would call the api every time it was mounted. Now, api calls are made in the store so they can be cached. The component will request its data from the store and the api will only be called if an hour has passed since the last report was received.
Added Vuex-persistedstate module
Using persisted state module to store owmReport in localstorage