Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant api calls for fits headers #102

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

timbeccue
Copy link
Collaborator

Previously, accessing the fits header for an image required an api call to fetch it. Since header data is now included when images are loaded, we don't need to make a separate call each time we want to access a new image's header info.

This change removes the api calls from the fits header modal component, and uses the header data that is already included in the image's metadata object.

@timbeccue timbeccue requested a review from capetillo September 28, 2023 18:14
Copy link
Contributor

@capetillo capetillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will affect anything else. Looks good!

@timbeccue timbeccue merged commit 931b544 into dev Sep 28, 2023
1 check passed
@timbeccue timbeccue deleted the feature/header-modal-cleanup branch September 28, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants