Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photometry omit large sources #391

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Photometry omit large sources #391

merged 5 commits into from
Apr 23, 2024

Conversation

cmccully
Copy link
Collaborator

This PR removes sources with an area of more than 1000 pixels before we attempt to deblend or calculate flux radii. This should prevent long-running photometry issues like we had on tfn1m014-fa20-20240306-0175-e91.

Matt I recommend running your photometry gist to confirm: https://gist.github.com/mgdaily/aabb6fc8d97a50a09ec15315ce4aab63

@cmccully cmccully requested a review from mgdaily April 23, 2024 16:55
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this takes 7 seconds on the formerly problematic image. fluxfrac_radius now runs to completion almost instantaneously. Nice work

@cmccully cmccully merged commit 8c20311 into main Apr 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants