Use libsodium-sys-stable crate which is maintained, instead of abandonned libsodium-sys #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our dependency on the abandoned libsodium-sys to use the libsodium-sys-stable crate from crates.io, which is maintained (it lives here).
It also removes the libsodium-sys code that was duplicated in this repo.
The crate compiles and the tests run successfully (except for 3 doc tests that don't seem to be very relevant). I have also validated that the test suite of
kuska-handshakeworks correctly when using this version.I have bumped the version in Cargo.toml to v0.3.0, and I suggest uploading a new version of this to crates.io if this patch is accepted. Then I will submit a patch on kuska-handshake to do the update there so that it depends on the new version as well.