Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative symlink paths when creating links #399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

riclage
Copy link
Contributor

@riclage riclage commented Jul 3, 2024

#335 introduced a bug when creating a backlink in notes files pointed to a symbolic link.

(org-brain-entry-path choice) already uses file-truename and thus returns the actual source path. buffer-file-name returns the path in the symbolic link, creating the inconsistent match.

For both paths to match, this change simply adds a file-truename call to get the actual source of buffer-file-name.

riclage added 2 commits July 3, 2024 22:45
Changes:
- Remove condition to check for file modification date
- Add new id to existing cache every time org-brain-get-id() is called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant