made all vars buffer local for [Suggest] Add viewport feature #339 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ten#339 Now you can just M-x rename-buffer then start a new org-brain to look at and/or manipulate the org-brain from different locations. So far there doesn't seem to be any problems with the underlying org files getting munged, probably because org-brain seems to immediately save them after making changes. There may need to be some kind of locking if one thing was changed but not exited/saved immediately, then another thing changed and saved, then the first thing saved. I haven't had the time to actually check this as this is not my workflow.
looks like the changes I did to make all vars buffer local got backed out
instead of always in insert which was annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can just M-x rename-buffer then start a new org-brain to look
at and/or manipulate the org-brain from different locations.
So far there doesn't seem to be any problems with the underlying org
files getting munged, probably because org-brain seems to immediately
save them after making changes. There may need to be some kind of
locking if one thing was changed but not exited/saved immediately,
then another thing changed and saved, then the first thing saved.
I haven't had the time to actually check this as this is not my
workflow.