-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org-brain category color feature #329
base: master
Are you sure you want to change the base?
Conversation
* org-brain.el (org-brain-title-max-width): New function. (org-brain-insert-visualize-button): Add max-width argument. (org-brain--vis-parents-siblings, org-brain--vis-friends) (org-brain--vis-children): use org-brain-title-max-width function.
34cf692
to
6ae91e6
Compare
I could see a use-case for this if you want different faces for different topics or similar. Maybe though instead of creating a new |
The category has a problem, it is hard code inheritance, can it be controled by org-use-property-inheritance ?
|
I don't know, but isn't inheritance usually what you want in this case? To me it seems a bit confusing if there's one thing called a "category" and another called a "group". I the only purpose of the group feature is to add colors, then maybe it should be named accordingly (like "color props" or something similar). |
the name "group" is a temp name, for I do not find a better name at the moment :-)
I will try to test CATEGORY property. |
I have found a way to disable category's inheritance, I will rename group to category |
3c8826a
to
8ffa515
Compare
* org-brain.el (org-brain-category-face-alist): New variable. (org-brain-display-face): Handle org-brain category. (org-brain-get-category): New function. (org-brain-set-selected-category): New function. (org-brain-set-category): new function. (org-brain-category-and-title<): New function. (org-brain-visualize-mode-map, org-brain-select-map): Handle keybindings of group commands (org-brain-insert-visualize-button): use max-width when org-brain-category-face-alist non-nil.
@Kungsgeten I have rename group to category, please review again, thanks. |
@Kungsgeten ping |
Two more ideas:
One more extra thought, because related: |
How is the coloring caused in above examples? |
Hello:
I want to let different entries have different color, so I add org-brain group (maybe other name) feature.
any suggestion?