-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth and multi-extension integration tests #99
Conversation
ea50d39
to
0acd3e0
Compare
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
Signed-off-by: Adam Cattermole <[email protected]>
0acd3e0
to
ccf0d7f
Compare
4, 72, 84, 84, 80, 82, 20, 10, 4, 104, 111, 115, 116, 18, 12, 97, 117, 116, 104, | ||
99, 111, 110, 102, 105, 103, 45, 65, 90, 0, | ||
]), | ||
Some(5000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to set the timeout config when #101 is merged
|
||
#[test] | ||
#[serial] | ||
fn it_performs_authenticated_rate_limiting() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💛
|
||
#[test] | ||
#[serial] | ||
fn unauthenticated_does_not_ratelimit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new tests cover some of the user guides we provide in our docs, so this is perfect. Also, great bonus cleaning the code 🥇
Fixed a couple minor points in the configuration (defaults + dead_code) as well as updating existing tests for the new fields.
Added two new files to perform some of the integration tests for auth as well as multi-extension operation (authenticated rate limiting).
Multi-extension tests currently don't pass as there's a bug fix in #98 where the headers were being retrieved for every extension.