[refactor] Fixing flow of http request on grpc response

Signed-off-by: dd di cesare <[email protected]>
Kuadrant · Oct 31, 2024 · 06f654f · 06f654f
1 parent 346d035
commit 06f654f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/filter/http_context.rs b/src/filter/http_context.rs
@@ -133,13 +133,17 @@ impl Context for Filter {
                 if GrpcService::process_grpc_response(operation, resp_size).is_ok() {
                     // call the next op
                     match self.operation_dispatcher.borrow_mut().next() {
-                        Ok(_) => {} // no action needed
+                        Ok(some_op) => {
+                            if some_op.is_none() {
+                                // No more operations left in queue, resuming
+                                self.resume_http_request();
+                            }
+                        }
                         Err(op_err) => {
                             // If desired, we could check the error status.
                             GrpcService::handle_error_on_grpc_response(op_err.failure_mode);
                         }
                     }
-                    self.resume_http_request();
                 }
             }
             Err(e) => {

diff --git a/src/service.rs b/src/service.rs
@@ -85,7 +85,7 @@ impl GrpcService {
         match failure_mode {
             FailureMode::Deny => {
                 hostcalls::send_http_response(500, vec![], Some(b"Internal Server Error.\n"))
-                    .unwrap()
+                    .unwrap();
             }
             FailureMode::Allow => hostcalls::resume_http_request().unwrap(),
         }