🔥 conditions et at, replacing with proper cel::Predicates & ::Expressions

doc/migrations/conditions.md

@@ -23,22 +23,3 @@ case `foo` was the identifier of the variable, while `bar` was the value to eval
 after the operator `==` would be equally important. SO that `foo  ==  bar` would test for a `foo ` variable being equal
 to ` bar` where the trailing whitespace after the identifier, and the one prefixing the value, would have been
 evaluated.
-
-## Server binary users
-
-The server still allows for the deprecated syntax, but warns about its usage. You can easily migrate your limits file, 
-using the following command:
-
-```commandline
-limitador-server --validate old_limits.yaml > updated_limits.yaml
-```
-
-Which should output `Deprecated syntax for conditions corrected!` to `stderr` while `stdout` would be the limits using 
-the new syntax. It is recommended you manually verify the resulting `LIMITS_FILE`.
-
-
-## Crate users
-
-A feature `lenient_conditions` has been added, which lets you use the syntax used in previous version of the crate.
-The function `limitador::limit::check_deprecated_syntax_usages_and_reset()` lets you verify if the deprecated syntax 
-has been used as `limit::Limit`s are created with their condition strings using the deprecated syntax.

doc/server/configuration.md

@@ -94,7 +94,7 @@ Here is an example of such a limit definition:
   max_value: 10
   seconds: 60
   conditions:
-    - "req.method == 'GET'"
+    - "req_method == 'GET'"
   variables:
     - user_id
 ```

limitador-server/Cargo.toml

@@ -18,7 +18,7 @@ distributed_storage = ["limitador/distributed_storage"]
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-limitador = { path = "../limitador", features = ['lenient_conditions'] }
+limitador = { path = "../limitador" }
 tokio = { version = "1", features = ["full"] }
 thiserror = "2"
 tonic = "0.12.3"

limitador-server/examples/envoy.yaml

@@ -29,7 +29,7 @@ static_resources:
                     - stage: 0
                       actions:
                         - {request_headers: {header_name: "userid", descriptor_key: "user_id"}}
-                        - {request_headers: {header_name: ":method", descriptor_key: "req.method"}}
+                        - { request_headers: { header_name: ":method", descriptor_key: "req_method" } }
           http_filters:
           - name: envoy.filters.http.ratelimit
             typed_config:

limitador-server/examples/limits.yaml

@@ -10,6 +10,6 @@
   max_value: 5
   seconds: 60
   conditions:
-    - "req.method == 'POST'"
+    - "req_method == 'POST'"
   variables:
     - user_id

limitador-server/sandbox/README.md

@@ -99,11 +99,11 @@ bin/grpcurl -plaintext -d @ 127.0.0.1:18081 envoy.service.ratelimit.v3.RateLimit
         {
             "entries": [
                 {
-                    "key": "req.method",
+                    "key": "req_method",
                     "value": "POST"
                 },
                 {
-                    "key": "req.path",
+                    "key": "req_path",
                     "value": "/"
                 }
             ]
@@ -125,11 +125,11 @@ while :; do bin/grpcurl -plaintext -d @ 127.0.0.1:18081 envoy.service.ratelimit.
         {
             "entries": [
                 {
-                    "key": "req.method",
+                    "key": "req_method",
                     "value": "POST"
                 },
                 {
-                    "key": "req.path",
+                    "key": "req_path",
                     "value": "/"
                 }
             ]

limitador-server/sandbox/envoy.yaml

@@ -27,10 +27,10 @@ static_resources:
                           - actions:
                             - request_headers:
                                 header_name: :method
-                                descriptor_key: req.method
+                                descriptor_key: req_method
                             - request_headers:
                                 header_name: :path
-                                descriptor_key: req.path
+                                descriptor_key: req_path
             http_filters:
             - name: envoy.filters.http.ratelimit
               typed_config:

limitador-server/sandbox/envoy2.yaml

@@ -27,10 +27,10 @@ static_resources:
                           - actions:
                             - request_headers:
                                 header_name: :method
-                                descriptor_key: req.method
+                                descriptor_key: req_method
                             - request_headers:
                                 header_name: :path
-                                descriptor_key: req.path
+                                descriptor_key: req_path
             http_filters:
             - name: envoy.filters.http.ratelimit
               typed_config: