e2e limits_file_watcher_on_docker #387
Conversation
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
new-e2e-bases-on-docker
branch
from
c9708d4 to
ea9bce8
Compare
|
What is this test trying to assert? That we can observe filesystem changes when running within a docker container? |
| # the entire path needs to be mounted | ||
| # or inotify events are not triggered for updates on the mounted file |
There was a problem hiding this comment.
This is a comment to warn about some configuration that, for unknown reason to me yet, events are not triggered when the file changes. That happens exactly when the file is mounted.
When the parent dir is mounted, then events are triggered whenever the limits file is updated.
Yes, This e2e test makes sure it works and nothing broke it. |
There was a problem hiding this comment.
Right, but that's the same behavior as if watching the local FS... So not saying this isn't useful, but it's a lot of jumping through hoops to validate this...
The one downside I see, is that we keep on adding things to the e2e w/o adding much safety nets at the unit cargo test layer. I personally favor quick feedback loops, and e2e tests are both cumbersome and slow to run (and generally will run on CI, which makes that time even longer).
I guess lets add this, see it ever catches anything and see from there. i.e. if it fails, lets make sure we add some quick test that prove its fixed, so we catch it sooner in the future.
No description provided.