Refactor metrics layer implementation #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tried to slightly improve the metrics layer implementation:
contains
to_string
calls and passing refgroup_times
and instead only clone the keysfmt_layer
andtelemetry_layer
have been moved to independent functions for type inferencetelemetry_layer
- there were no metrics when the endpoint was provided so it is now set independently on thetelemetry_layer
(in the new fn)datastore
spans to be info level apart from for disk storage where they are debug