Refactor levels for metrics, logging, and tracing #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-cattermole
commented
May 28, 2024
| .with(telemetry_layer) | ||
| .init(); | ||
| } else { | ||
| tracing_subscriber::registry() | ||
| .with(level) |
There was a problem hiding this comment.
Worth mentioning that removing this global level filter means all spans hit the metrics layer regardless of the configured verbosity now
adam-cattermole
force-pushed
the
tracing-info-level
branch
from
7dd5924 to
67e9427
Compare
alexsnaps
approved these changes
May 28, 2024
adam-cattermole
force-pushed
the
tracing-info-level
branch
from
67e9427 to
ab96ec5
Compare
|
I've done some initial investigation into the performance effects of this and we came to the conclusion that this is acceptable so going to merge. Going to continue to performance profile and will provide a further PR if I can determine any potential performance improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fmt_layer(logging layer)INFOminimum, however still configurable by verbosity toDEBUG/TRACE