[distributed store] Batch up updates per session. #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirino
force-pushed
the
distributed-batcher
branch
from
c07bac5 to
2ffd28e
Compare
This allows connecting slow peers without affecting how quickly We can replicate to fast peers. Signed-off-by: Hiram Chirino <[email protected]>
chirino
force-pushed
the
distributed-batcher
branch
from
2ffd28e to
3baf07b
Compare
|
rebased off main |
alexsnaps
approved these changes
May 27, 2024
There was a problem hiding this comment.
I think this could be "simplified" from a "design" perspective and as such avoid some .clone() et al... Have a slightly more "fluid" data flow. But I could also be wrong. Let's keep on moving forward and revisit when we have a better overview of the whole solution and have our back covered with more tests :)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.