Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs comming from forks do not push images #305

Closed
wants to merge 5 commits into from

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Apr 30, 2024

What

GH action runs on pushes coming from forked PR's do not have permissions to access docker image repo in quay.io.

This PR adds some conditionals to skip those steps that would fail otherwise.

But building the image and running smoke tests on the image is still a value for forked PR's, so allowing them as a separated job. Not doing multi-arch build with layer caching as the regular image building, though.

Tested

  • Pushes from kuadrant users
  • Pushes from external users (forked PR's)
  • Tags

Copy link
Member

@alexsnaps alexsnaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this should work... I was a bit fast at merging #306 - it doesn't fix it. Probably need to revert it... my bad

@eguzki eguzki changed the title forks do not have permissions to push images PRs comming from forks do not push images May 2, 2024
@eguzki eguzki force-pushed the forks-not-running-image-build branch from 862ce61 to 66679d2 Compare May 2, 2024 08:45
@eguzki
Copy link
Contributor Author

eguzki commented May 2, 2024

Currenlty, the even trigger configuration prevents image building from PRs from forked repos.

on:
  workflow_dispatch:
  push:
    branches: ['*']
    tags: ['*']

the push event is never triggered on PR's from forked repos because there is no new commits/tags in the kuadrant's repo, but instead in another repo.

@eguzki eguzki closed this May 2, 2024
@eguzki eguzki deleted the forks-not-running-image-build branch May 2, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants