Refactor the way we deal with partitions #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
force-pushed
the
refactor-partition
branch
from
3709bbb to
577cd74
Compare
adam-cattermole
approved these changes
Apr 19, 2024
didierofrivia
approved these changes
Apr 19, 2024
alexsnaps
force-pushed
the
refactor-partition
branch
from
b732c41 to
9d5eed7
Compare
|
LGTM, including the new changes that makes easier to manage the partition and simplifies within the batch update the check with just boolean instead of the Future |
|
Yep, the updates lgtm, makes sense to pass the bool instead of future and check if partitioned on each flushing interval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes for more consistent logging of the encountering a partition...
There is a todo that we need to fix, not losing the counters that have not been written out to Redis, when the partition occurs in the middle of flushing the batch.