-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New time metric aggregation layer and refactor of prometheus metrics #267
New time metric aggregation layer and refactor of prometheus metrics #267
Conversation
4c8b4d9
to
975b701
Compare
975b701
to
6aba190
Compare
I am trying to understand what is this doing. |
The primary difference is the way that those metrics are collected at /metrics @eguzki. Before the calculation was all being done inline with time instants wrapping the sections of code that access the datastore in the library. It's now been abstracted outside of the library, with all of the latency metrics being calculated through a new metrics layer instrumenting the spans. The result is two primary changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff... but otherwise LGTM
6aba190
to
0cf8bd3
Compare
Adds a new metrics layer to the tracing configuration which times accesses to different spans.
gather
accepts:group
: the parent span to combine forconsumer
: a function to perform some kind of operation on theTimings
collected for thisgroup
records
: a list of different sub-spans ofgroup
that should be summed togetherIt's currently set up to sum all
datastore
span accesses for ashould_rate_limit
callRefactor