Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Result.unwrap usages #280

Open
alexsnaps opened this issue Mar 22, 2024 · 1 comment
Open

Clean up Result.unwrap usages #280

alexsnaps opened this issue Mar 22, 2024 · 1 comment

Comments

@alexsnaps
Copy link
Member

alexsnaps commented Mar 22, 2024

Adding the lint to our crate and server code should help finding and going about them

diff --git a/limitador-server/src/main.rs b/limitador-server/src/main.rs

-#![deny(clippy::all, clippy::cargo)]
+#![deny(clippy::all, clippy::cargo, clippy::unwrap_used)]
 
diff --git a/limitador/src/lib.rs b/limitador/src/lib.rs
 
-#![deny(clippy::all, clippy::cargo)]
+#![deny(clippy::all, clippy::cargo, clippy::unwrap_used)]

Not that all necessary have to go, but probably cleaning some of these up and possibly swapping them for .expect() would be desirable.

Crate has ~68 of them, while the server code has ~29 calls to unwrap() across all features

This probably relates to #131

@alexsnaps
Copy link
Member Author

These is dependency to #131 for doing this properly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant