Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-network-ipaddresspool.sh: dedicated IP address range #422

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Feb 14, 2024

Turns out that using the entire kind subnet address space leads to conflicts.

The kind network is exposed to the host using the X.Y.0.1. Metallb will assign X.Y.0.0 to the first service of LB type. Then it will assign X.Y.0.1 to the second service of LB type. This second service will not be reachable as the IP conflicts with the host IP inside kindnetwork.

The fix is to derive an IP address range that lives in the kind network from the X.Y.0.0/16 subnet. The PR #418 removed this derivation and this PR is bringing that back in place.

@eguzki eguzki requested a review from a team as a code owner February 14, 2024 22:36
@eguzki eguzki requested a review from mikenairn February 14, 2024 22:36
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Merging #422 (fedd767) into main (8bf2d55) will decrease coverage by 0.72%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   66.16%   65.44%   -0.72%     
==========================================
  Files          38       38              
  Lines        3901     3901              
==========================================
- Hits         2581     2553      -28     
- Misses       1132     1154      +22     
- Partials      188      194       +6     
Flag Coverage Δ
integration 69.81% <ø> (-1.38%) ⬇️
unit 60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 78.59% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.44% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 69.81% <ø> (-1.38%) ⬇️

see 6 files with indirect coverage changes

@eguzki eguzki merged commit c831a70 into main Feb 15, 2024
22 checks passed
@eguzki eguzki deleted the docker-network-ipaddresspool-ip-range branch February 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants