Disable fail-fast for nightly integration tests

[adam-cattermole]

When the nightly integration tests run if one of the sail operator / istioctl fails the other test in the matrix is cancelled due to fail-fast: true. Setting to false so we run both integration tests no matter the outcome of the first to complete.

See latest nightly here where the integration test for sail cancelled the integration test for istioctl:
https://github.com/Kuadrant/kuadrant-operator/actions/runs/7634245121

[codecov]

Codecov Report

Merging #405 (9a3f7a9) into main (d8c4f6a) will decrease coverage by 0.76%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   66.50%   65.75%   -0.76%     
==========================================
  Files          38       38              
  Lines        3863     3901      +38     
==========================================
- Hits         2569     2565       -4     
- Misses       1110     1146      +36     
- Partials      184      190       +6     

Flag	Coverage Δ
integration	70.40% <ø> (-1.55%)	⬇️
unit	60.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	∅ <ø> (∅)
pkg/common (u)	78.59% <ø> (ø)
pkg/istio (u)	37.11% <ø> (ø)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	33.44% <ø> (ø)
pkg/rlptools (u)	56.46% <ø> (ø)
controllers (i)	70.40% <ø> (-1.55%)	⬇️

see 7 files with indirect coverage changes

[Boomatang]

For nightly tests this makes sense. Does this affect standard PR checks? On PRs it might be better to fail fast and not using the extra resources.

[adam-cattermole]

At the moment it doesn't affect PR's as only one of the matrix options is run (istioctl). In my opinion even if we reintroduce the integration tests on sail operator for PR's I think it makes more sense for both to run in case a change breaks integration in one and not the other?

[KevFan]

LGTM !