Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for configuration reconcile #404

Merged
merged 6 commits into from
May 15, 2024

Conversation

Boomatang
Copy link
Contributor

@Boomatang Boomatang commented Jan 23, 2024

Part of: #305

Add integration test for testing the reconcile of limitador configuration in the kuadrant CR into the limitador CR.

@Boomatang Boomatang added this to the v0.7.0 milestone Jan 23, 2024
@Boomatang Boomatang self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (ece13e8) to head (19928df).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   80.20%   82.60%   +2.39%     
==========================================
  Files          64       72       +8     
  Lines        4492     5415     +923     
==========================================
+ Hits         3603     4473     +870     
- Misses        600      634      +34     
- Partials      289      308      +19     
Flag Coverage Δ
integration 74.08% <ø> (+2.80%) ⬆️
unit 33.73% <ø> (+3.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 93.58% <100.00%> (+2.16%) ⬆️
pkg/common (u) 83.78% <ø> (-5.05%) ⬇️
pkg/istio (u) 75.86% <ø> (+1.94%) ⬆️
pkg/log (u) 100.00% <ø> (+5.26%) ⬆️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 80.84% <83.95%> (+4.04%) ⬆️

see 37 files with indirect coverage changes

@Boomatang Boomatang force-pushed the sub_component/intergration_test branch from 9a5cff5 to 86f5417 Compare January 25, 2024 09:36
Boomatang added 2 commits May 2, 2024 12:50
Add kuadrant CR configuration to limitador CR configuration
@Boomatang Boomatang force-pushed the sub_component/intergration_test branch from 86f5417 to b17c8ed Compare May 2, 2024 12:17
@Boomatang Boomatang force-pushed the sub_component/intergration_test branch from b17c8ed to 85ca7d4 Compare May 2, 2024 13:29
@Boomatang Boomatang changed the title [WIP] Integration tests Integration tests for configuration reconcile May 7, 2024
@Boomatang Boomatang marked this pull request as ready for review May 7, 2024 08:51
@Boomatang Boomatang requested a review from a team as a code owner May 7, 2024 08:51
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left some minor nits / comments

@Boomatang Boomatang merged commit 3d2f65d into main May 15, 2024
20 checks passed
@Boomatang Boomatang deleted the sub_component/intergration_test branch May 15, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants