-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests for configuration reconcile #404
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 80.20% 82.60% +2.39%
==========================================
Files 64 72 +8
Lines 4492 5415 +923
==========================================
+ Hits 3603 4473 +870
- Misses 600 634 +34
- Partials 289 308 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9a5cff5
to
86f5417
Compare
Add kuadrant CR configuration to limitador CR configuration
86f5417
to
b17c8ed
Compare
b17c8ed
to
85ca7d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left some minor nits / comments
Part of: #305
Add integration test for testing the reconcile of limitador configuration in the kuadrant CR into the limitador CR.