wip: Rename configmap for sail

[adam-cattermole]

Test to see if this fixes sail integration tests until we can pin version.

I don't like the solution will look at refactoring.

[codecov]

Codecov Report

Merging #392 (c1ab8d1) into main (f3a0b66) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   65.87%   65.87%   -0.01%     
==========================================
  Files          35       35              
  Lines        3795     3792       -3     
==========================================
- Hits         2500     2498       -2     
  Misses       1112     1112              
+ Partials      183      182       -1     

Flag	Coverage Δ
unit	58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	∅ <ø> (∅)
pkg/common (u)	76.92% <ø> (ø)
pkg/istio (u)	37.11% <ø> (ø)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	33.21% <ø> (ø)
pkg/rlptools (u)	56.46% <ø> (ø)
controllers (i)	71.97% <ø> (+<0.01%)	⬆️

Files	Coverage Δ
controllers/kuadrant_controller.go	51.80% <ø> (-0.13%)	⬇️

[guicassolato]

I wonder if this function doesn't belong to pkg/istio/mesh_config.go. It looks like the name of the ConfigMap is an implementation detail of each kind of Istio operator.

If this is indeed the direction we want to go, WDYT about something like the following?

func (r *KuadrantReconciler) getIstioConfigObjects(ctx context.Context, logger logr.Logger) ([]common.ConfigWrapper, error) {
	// ...
	if err == nil || apierrors.IsNotFound(err) {
		opw := istio.NewOperatorWrapper(iop)
		configMapName = opw.ConfigMapName()
		configsToUpdate = append(configsToUpdate, opw)
	} else if !apimeta.IsNoMatchError(err) {
		// ...
	} else {
		// ...
		opw := istio.NewSailWrapper(ist)
		configMapName = opw.ConfigMapName()
		configsToUpdate = append(configsToUpdate, opw)
	}
	// ...
}

Of course, OperatorWrapper and SailWrapper structs would implement ConfigMapName() string as well (apart from ConfigWrapper).

[adam-cattermole]

Yep that's along the lines of what I was thinking. Unfortunately these changes aren't enough though to solve the install issue, still investigating.

[adam-cattermole]

I'm going to close this in favour of #391 - the istio CR must be named default, which results in the configmap being named istio which is our normal case. If the istio CR name can be configured down the line then we will need to handle this case where the configmap is named istio-<istio-cr-name>