Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc/user-guides/secure-protect-connect.md #374

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update doc/user-guides/secure-protect-connect.md #374

merged 2 commits into from
Dec 12, 2023

Conversation

maleck13
Copy link
Collaborator

Co-authored-by: Jason Madigan [email protected]

number and fix link

remove uneeded resolve

remove unneeded var

@maleck13 maleck13 requested a review from a team as a code owner December 12, 2023 14:51
@maleck13 maleck13 mentioned this pull request Dec 12, 2023
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #374 (2d6bc1e) into main (0e08054) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   65.41%   65.44%   +0.02%     
==========================================
  Files          35       35              
  Lines        3843     3843              
==========================================
+ Hits         2514     2515       +1     
  Misses       1132     1132              
+ Partials      197      196       -1
Flag Coverage Δ
integration 70.73% <ø> (+0.04%) ⬆️
unit 59.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 37.11% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.73% <ø> (+0.04%) ⬆️

see 4 files with indirect coverage changes

jasonmadigan
jasonmadigan reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@jasonmadigan jasonmadigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to have addressed all of @guicassolato's feedback

maleck13 and others added 2 commits December 12, 2023 19:08
@maleck13
Update doc/user-guides/secure-protect-connect.md
6626b99 
Co-authored-by: Jason Madigan <[email protected]>

number and fix link

remove uneeded resolve

remove unneeded var
@guicassolato @maleck13
enhancements to the secure-protect-connect user guide
2d6bc1e
@maleck13 maleck13 force-pushed the gh-361-minor-updates branch from aa6326e to 2d6bc1e Compare December 12, 2023 19:08
maleck13
maleck13 commented Dec 12, 2023
View reviewed changes
Copy link
Collaborator Author

@maleck13 maleck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I can't approve it

@maleck13 maleck13 merged commit 0c65df1 into main Dec 12, 2023
22 checks passed
@eguzki eguzki deleted the gh-361-minor-updates branch December 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki left review comments

@jasonmadigan jasonmadigan jasonmadigan left review comments

@guicassolato guicassolato guicassolato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maleck13 @jasonmadigan @eguzki @guicassolato