Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.0 #343

Closed
wants to merge 1 commit into from
Closed

Release v0.5.0 #343

wants to merge 1 commit into from

Conversation

alexsnaps
Copy link
Member

@alexsnaps alexsnaps commented Nov 28, 2023

Not a PR to merge, just checking this is correct and we can run the job:

❯ make bundle IMAGE_TAG=v0.5.0 REGISTRY=quay.io VERSION=0.5.0 REPLACES_VERSION=0.4.1 CHANNELS=stable LIMITADOR_OPERATOR_VERSION=0.7.0 AUTHORINO_OPERATOR_VERSION=0.10.0 WASM_SHIM_VERSION=0.3.0

see how this goes...

@alexsnaps alexsnaps requested a review from a team as a code owner November 28, 2023 16:43
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #343 (6d706c5) into main (f17aadb) will increase coverage by 0.39%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   64.64%   65.03%   +0.39%     
==========================================
  Files          35       35              
  Lines        3804     3804              
==========================================
+ Hits         2459     2474      +15     
+ Misses       1147     1134      -13     
+ Partials      198      196       -2     
Flag Coverage Δ
integration 70.08% <ø> (+0.74%) ⬆️
unit 59.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 76.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.21% <ø> (ø)
pkg/rlptools (u) 56.46% <ø> (ø)
controllers (i) 70.08% <ø> (+0.74%) ⬆️

see 5 files with indirect coverage changes

@didierofrivia
Copy link
Member

something to comment that I'll also add it to the RFC:

The push event that triggers the build of the images are not passing all the params needed. I usually cancel it, then trigger manually the workflow_dispatch "Build Images" with the same params you ran the make bundle

@didierofrivia
Copy link
Member

I reckon the manifest failed because of your local version of controller-gen

@alexsnaps alexsnaps force-pushed the release-v0.5.0 branch 2 times, most recently from 8a06bd7 to 781c23c Compare December 4, 2023 16:16
Copy link
Contributor

@guicassolato guicassolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didierofrivia
Copy link
Member

Oops, @guicassolato we (royal) forgot to do it the last time, but yes, we should do it

@alexsnaps
Copy link
Member Author

So, I will redo this yet again, but I challenge the usefulness of the changelog in this case...
where/how do we plan on distributing that changelog? If it has no use, I think we should just not have it at all.
I don't know (if at all) where that changelog is currently made available to end users... can someone shed some light?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants