-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: TLS and DNS Policy user guides #322
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 64.28% 64.97% +0.68%
==========================================
Files 35 35
Lines 3794 3794
==========================================
+ Hits 2439 2465 +26
+ Misses 1158 1131 -27
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -4,9 +4,14 @@ apiVersion: kind.x-k8s.io/v1alpha4 | |||
nodes: | |||
- role: control-plane | |||
image: kindest/node:v1.27.3 | |||
# port forward 80 on the host to 80 on this node | |||
extraPortMappings: | |||
- containerPort: 30950 | |||
hostPort: 9080 | |||
- containerPort: 30951 | |||
hostPort: 9443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to use metalb in the default setup we can probably drop these ports and use 9080 -> 80, 9443 -> 443
8889950
to
d5287a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs look ok, I tihnk it would be good to pull out the common setup stuff and keep each doc just focused on the task, that way if you move from one to the other you can just get on with it.
Also we need to change the ref version in Gateways to be v1
392b962
to
f076e65
Compare
f076e65
to
aac54d8
Compare
aac54d8
to
f0b9534
Compare
* Add deploy-policy-controller and undeploy-policy-controller, deploys/undeploys the policy-controller into/from the kuadrant-system namespace. * Update dns and tls guides with extra step to install policy-controller.
f0b9534
to
e9504db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mikenairn the issue is with the 8080 port in the tests |
Yeah sure, 8080 was probably a bad choice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went through all the steps. Worked as expected. Once we have a single cluster quick start then we prob want to drop some of these steps but this is good for now.
* docs: TLS and DNS Policy user guides * docs: Update after removal of policy-controller from bundle * Add deploy-policy-controller and undeploy-policy-controller, deploys/undeploys the policy-controller into/from the kuadrant-system namespace. * Update dns and tls guides with extra step to install policy-controller. * Add script to generate MetalLB IPAddressPool for docker network. * Change kind cluster ports 80 -> 9081, 443 -> 9444
Add user guide documentation for TLS and DNS Policy focused on the single cluster context and using the simple routing strategy for DNS.
To support the DNS and TLS policy guides, updates were made to install and configure, metallb and the policy controller:
make install-metallb