Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix user guide authenticated rl for app devs based on authpolicy/v1beta2 #282

Merged
merged 1 commit into from
Oct 25, 2023
Merged

docs: fix user guide authenticated rl for app devs based on authpolicy/v1beta2 #282

merged 1 commit into from
Oct 25, 2023

Conversation

guicassolato
Copy link
Contributor

No description provided.

@guicassolato guicassolato requested a review from a team as a code owner October 25, 2023 10:13
@guicassolato guicassolato self-assigned this Oct 25, 2023
@guicassolato guicassolato added kind/bug Something isn't working area/doc Improvements or additions to documentation target/current size/small labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #282 (e087a8b) into main (6bffa0b) will decrease coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   65.44%   64.73%   -0.71%     
==========================================
  Files          35       35              
  Lines        3806     3806              
==========================================
- Hits         2491     2464      -27     
- Misses       1131     1150      +19     
- Partials      184      192       +8
Flag Coverage Δ
integration 70.43% <ø> (-1.33%) ⬇️
unit 58.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
pkg/common (u) 73.92% <ø> (ø)
pkg/istio (u) 30.24% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 33.68% <ø> (ø)
pkg/rlptools (u) 56.41% <ø> (ø)
controllers (i) 70.43% <ø> (-1.33%) ⬇️

see 6 files with indirect coverage changes

Boomatang
Boomatang approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as expected

@guicassolato guicassolato merged commit 7d0f44e into main Oct 25, 2023
18 checks passed
@guicassolato guicassolato deleted the docs/fix-authenticated-rl-user-guide branch October 25, 2023 12:39
@guicassolato guicassolato mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boomatang Boomatang Boomatang approved these changes

Assignees

@guicassolato guicassolato

Labels
area/doc Improvements or additions to documentation kind/bug Something isn't working size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicassolato @Boomatang