kuadrant gateway controller to annotate gateways

[eguzki]

What

Fixes #259

Custom controller to add the kuadrant annotation to every new gateway deployed after Kuadrant CR has been created.

It does not reconcile the annotation value. If there is an annotation with the expected key kuadrant.io/namespace

Fixed codecov configuration.

❯ cat .github/codecov.yaml | curl --data-binary @- https://codecov.io/validate
Valid!

Verification Steps

• Setup the environment:

make local-setup         

Checking the annotations of the istio-ingressgateway gateway

❯ k get gateways istio-ingressgateway -n istio-system -o jsonpath='{.metadata.annotations}' | yq e 'keys' -P

It does not have any kuadrant namespace annotation

- kubectl.kubernetes.io/last-applied-configuration

Request an instance of Kuadrant:

kubectl -n kuadrant-system apply -f - <<EOF
apiVersion: kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant
spec: {}
EOF

The istio istio-ingressgateway gateway, should be annotated with the kuadrant annotation

❯ k get gateways istio-ingressgateway -n istio-system -o jsonpath='{.metadata.annotations}' | yq e 'keys' -P

- kuadrant.io/namespace
- kubectl.kubernetes.io/last-applied-configuration

Create a new gateway

kubectl -n kuadrant-system apply -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: second
spec:
  gatewayClassName: istio
  listeners:
    - allowedRoutes:
        namespaces:
          from: All
      hostname: '*.example.com'
      name: api
      port: 80
      protocol: HTTP
EOF

Note that the gateway does not have kuadrant annotation

The new gateway second gateway, should be annotated with the kuadrant annotation

❯ k get gateways second -n kuadrant-system -o jsonpath='{.metadata.annotations}' | yq e 'keys' -P

- kuadrant.io/namespace
- kubectl.kubernetes.io/last-applied-configuration

[codecov]

Codecov Report

Merging #260 (833c448) into main (1eb8bdb) will decrease coverage by 0.26%.
The diff coverage is 79.71%.

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   63.85%   63.60%   -0.26%     
==========================================
  Files          32       33       +1     
  Lines        3135     3204      +69     
==========================================
+ Hits         2002     2038      +36     
- Misses        970      993      +23     
- Partials      163      173      +10     

Flag	Coverage Δ
integration	69.99% <79.71%> (-0.83%)	⬇️
unit	57.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	∅ <ø> (∅)
pkg/common (u)	75.90% <ø> (ø)
pkg/istio (u)	30.24% <ø> (ø)
pkg/log (u)	31.81% <ø> (ø)
pkg/reconcilers (u)	33.68% <ø> (ø)
pkg/rlptools (u)	57.63% <ø> (ø)
controllers (i)	69.99% <79.71%> (-0.83%)	⬇️

Files	Coverage Δ
controllers/gateway_kuadrant_controller.go	79.71% <79.71%> (ø)

... and 5 files with indirect coverage changes

[eguzki]

cc @andrewdavidmackenzie

Allow the coverage to drop by X%, and posting a success status.

[eguzki]

BTW new patch coverage raised up to 79.71%

[andrewdavidmackenzie]

Sounds good. Variability in test sampling can cause the % to vary a little (you can also specify the number of digits of rounding to do before comparing BTW), causing it to drop a little (with same code and tests) and fail - so this guards against that.

[andrewdavidmackenzie]

e.g.

coverage:
  round: up
  precision: 0

[eguzki]

TIL: codecov target

target

auto | <number>
Choose a minimum coverage ratio that the commit must meet to be considered a success.

    auto will use the coverage from the base commit (pull request base or parent commit) coverage to compare against.
    <number> you can specify a target of an exact coverage number such as 75% or 100% (string, int, or float accepted).