Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DNS Operator to grafana.com, example.md and kustomize.yaml #1119

Merged

Conversation

philbrookes
Copy link
Contributor

@philbrookes philbrookes commented Jan 15, 2025

  • Updated format of dns-operator dashboard to be compatible with grafana.com
  • Added DNS Operator dashboard to grafana.com (this appears to be pending publishing currently)
  • Updated example.md to show dns-operator dashboard
  • Added DNS Operator dashboard to observability kustomize.yaml
  • renamed file to accurately show .json

@philbrookes philbrookes force-pushed the dns-operator-example-dashboard branch 2 times, most recently from 6250324 to 1826eb1 Compare January 15, 2025 10:48
@david-martin
Copy link
Member

  • Updated format of dns-operator dashboard to be compatible with grafana.com

Checking, did you follow the instructions at Exporting a dashboard for use with Grafana Community Platform or other Grafana Instances , including the make dashboard-cleanup cmd after?
I think the datasource gave us trouble before, and those instructions and cmd were a way to get around that.

@mikenairn
Copy link
Member

mikenairn commented Jan 15, 2025

@david-martin Does anything extra need to be done to make sure when it is added that it has the same "kuadrant" tag as the others?
image

@david-martin
Copy link
Member

Does anything extra need to be done to make sure when it is added that it has the same "kuadrant" tag as the others?

Yeah, good catch.
You can add the tags in the UI and export again, or it should be safe to add directly to the json.
Here's an example
https://github.com/Kuadrant/kuadrant-operator/blob/main/examples/dashboards/app_developer.json#L1612-L1614

@philbrookes philbrookes force-pushed the dns-operator-example-dashboard branch 2 times, most recently from f276629 to 5891f90 Compare January 15, 2025 13:53
@philbrookes
Copy link
Contributor Author

Thanks, I've made those changes now.

@philbrookes philbrookes force-pushed the dns-operator-example-dashboard branch from 5891f90 to e9f84fd Compare January 15, 2025 13:57
Copy link
Member

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fitting the dashboard into the existing structure.

If you have any recommendations on making this process easier in future, I'm happy to help out.

Signed-off-by: Phil Brookes <pbrookes@redhat.com>
@philbrookes philbrookes force-pushed the dns-operator-example-dashboard branch from e9f84fd to 758f938 Compare January 15, 2025 15:35
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now
image

I'd consider renaming that to "DNS Dashboard" or maybe name them all in a similar way to some of the kubernetes ones e.g. "Kuadrant / DNS / Overview" but i don't think we need to decide on that here.

@philbrookes philbrookes merged commit aded954 into Kuadrant:main Jan 16, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants