Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect geo code in DNS docs #1111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect geo code in DNS docs #1111

wants to merge 1 commit into from

Conversation

mikenairn
Copy link
Member

GEO-US -> US

Only the following codes will be accepted with a "GEO-" prefix:

AWS_CONTINENT_CODE_AFRICA        = "AF"
AWS_CONTINENT_CODE_ANTARTICA     = "AN"
AWS_CONTINENT_CODE_ASIA          = "AS"
AWS_CONTINENT_CODE_EUROPE        = "EU"
AWS_CONTINENT_CODE_OCEANIA       = "OC"
AWS_CONTINENT_CODE_NORTH_AMERICA = "NA"
AWS_CONTINENT_CODE_SOUTH_AMERICA = "SA"

@mikenairn
Fix incorrect geo code in DNS docs
3721f13 
GEO-US -> US

Only the following codes will be accepted with a "GEO-" prefix:

```
AWS_CONTINENT_CODE_AFRICA        = "AF"
AWS_CONTINENT_CODE_ANTARTICA     = "AN"
AWS_CONTINENT_CODE_ASIA          = "AS"
AWS_CONTINENT_CODE_EUROPE        = "EU"
AWS_CONTINENT_CODE_OCEANIA       = "OC"
AWS_CONTINENT_CODE_NORTH_AMERICA = "NA"
AWS_CONTINENT_CODE_SOUTH_AMERICA = "SA"
```

Signed-off-by: Michael Nairn <[email protected]>
@Boomatang
Copy link
Contributor

As well as updating the docs can we add CEL validation to policy, so the user can't apply the a policy to the cluster with invalid codes?

@mikenairn mikenairn mentioned this pull request Jan 14, 2025
Open
@mikenairn
Copy link
Member Author

mikenairn commented Jan 14, 2025 •
edited
Loading

As well as updating the docs can we add CEL validation to policy, so the user can't apply the a policy to the cluster with invalid codes?

Probably could add a CEL validation for codes with the "GEO-" prefix since we have a provider agnostic list for those that we define. That's said, its not something i intend to look into now, or add to this PR. Created an issue for it #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmaas thomasmaas thomasmaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikenairn @Boomatang @thomasmaas