Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable build image trigger based on tags with -rc suffix #1107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Jan 10, 2025

Fix coming from #1105

@eguzki eguzki requested a review from maleck13 January 10, 2025 15:05
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (cc1b41f) to head (c981230).
Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   76.15%   83.54%   +7.39%     
==========================================
  Files         111       81      -30     
  Lines        8986     6764    -2222     
==========================================
- Hits         6843     5651    -1192     
+ Misses       1852      893     -959     
+ Partials      291      220      -71     
Flag Coverage Δ
bare-k8s-integration 15.58% <ø> (+4.70%) ⬆️
controllers-integration 75.90% <ø> (+17.03%) ⬆️
envoygateway-integration 40.54% <ø> (+8.04%) ⬆️
gatewayapi-integration 16.19% <ø> (+2.75%) ⬆️
istio-integration 43.65% <ø> (+9.32%) ⬆️
unit 20.05% <ø> (-5.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.92% <89.91%> (+2.49%) ⬆️

see 47 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant