Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update location of where kustomize looks for deploying example gateway #1090

Merged

Conversation

laurafitzgerald
Copy link
Contributor

@laurafitzgerald laurafitzgerald commented Dec 20, 2024

What

$subject so the user doesn't need to have a local copy of the repo to run the quickstart
also removing the need to have kustomize as a dependency for running the quickstart

Verification

Temporarily uninstall kustomize from your system.
Run curl "https://raw.githubusercontent.com/laurafitzgerald/kuadrant-operator/refs/heads/remove-local-repo-depedency/hack/quickstart-setup.sh"| bash
Reinstall kustomize

@@ -462,7 +462,7 @@ success "Kuadrant sample configuration deployed."

# Deploy gateway
info "Deploying example gateway ..."
kustomize build config/dependencies/istio/gateway | kubectl apply -f -
kustomize build ${KUADRANT_REPO_RAW}/config/dependencies/istio/gateway | kubectl apply -f -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried this but I am always wondering why write this in this fashion, why use a pipe?

kubectl apply -k ${KUADRANT_REPO_RAW}/config/dependencie/istio/gateway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because it's the output of kustomize build that's needed rather than the raw directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This I understand, the raw directory will fail if the -f flag is used. In my example it is the -k / --kustomize flag that is used. This requires a kustomization directory and under the hood will run kustomize build.

If you try using a file with the -k it will fail, like how -f fails with a directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay. I think that's what @david-martin is referring to also here -> Kuadrant/docs.kuadrant.io#161 (comment) so I will make those updates as part of this pr. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are ready for review now.

@laurafitzgerald laurafitzgerald force-pushed the remove-local-repo-depedency branch from 090fdc3 to afc4ede Compare January 6, 2025 11:33
@laurafitzgerald laurafitzgerald force-pushed the remove-local-repo-depedency branch from afc4ede to 5c05be8 Compare January 6, 2025 12:58
Copy link
Contributor

@Boomatang Boomatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me and works.

@laurafitzgerald
Copy link
Contributor Author

@Boomatang I notice the option to merge is Rebase and Merge rather than Merge pull request, I'm blocked from doing the latter. Is it correct to do the former?

@Boomatang
Copy link
Contributor

For me I have being using the Rebase and merge.

@laurafitzgerald laurafitzgerald merged commit ccbb507 into Kuadrant:main Jan 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants