Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WASM pull secret if protected registry #1083

Merged
merged 1 commit into from
Dec 19, 2024

Add logic to check prefix of image url and set an imagePullSecret

09dbeea
Select commit
Loading
Failed to load commit list.
Merged

Use WASM pull secret if protected registry #1083

Add logic to check prefix of image url and set an imagePullSecret
09dbeea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2024 in 0s

83.77% (+7.62%) compared to cc1b41f

View this Pull Request on Codecov

83.77% (+7.62%) compared to cc1b41f

Details

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.77%. Comparing base (cc1b41f) to head (09dbeea).
Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
controllers/envoy_gateway_extension_reconciler.go 61.53% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   76.15%   83.77%   +7.62%     
==========================================
  Files         111       81      -30     
  Lines        8986     6712    -2274     
==========================================
- Hits         6843     5623    -1220     
+ Misses       1852      870     -982     
+ Partials      291      219      -72     
Components Coverage Δ
api/v1beta1 (u) 90.00% <100.00%> (-2.19%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (+15.03%) ⬆️
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.67% <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.72% <89.17%> (+2.29%) ⬆️
Files with missing lines Coverage Δ
controllers/data_plane_policies_workflow.go 100.00% <ø> (ø)
controllers/istio_extension_reconciler.go 87.50% <100.00%> (+4.00%) ⬆️
controllers/envoy_gateway_extension_reconciler.go 83.54% <61.53%> (-1.00%) ⬇️

... and 36 files with indirect coverage changes