feat: validate limitador operator crd is installed for rate limit pol…

…icy status Signed-off-by: KevFan <[email protected]>
Kuadrant · Nov 13, 2024 · 9fa5b2d · 9fa5b2d
1 parent c57f528
commit 9fa5b2d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/controllers/data_plane_policies_workflow.go b/controllers/data_plane_policies_workflow.go
@@ -54,11 +54,11 @@ var (
 //+kubebuilder:rbac:groups=kuadrant.io,resources=ratelimitpolicies/status,verbs=get;update;patch
 //+kubebuilder:rbac:groups=kuadrant.io,resources=ratelimitpolicies/finalizers,verbs=update
 
-func NewDataPlanePoliciesWorkflow(client *dynamic.DynamicClient, isIstioInstalled, isEnvoyGatewayInstalled bool) *controller.Workflow {
+func NewDataPlanePoliciesWorkflow(client *dynamic.DynamicClient, isIstioInstalled, isEnvoyGatewayInstalled, isLimitadorOperatorInstalled bool) *controller.Workflow {
 	dataPlanePoliciesValidation := &controller.Workflow{
 		Tasks: []controller.ReconcileFunc{
 			(&AuthPolicyValidator{}).Subscription().Reconcile,
-			(&RateLimitPolicyValidator{}).Subscription().Reconcile,
+			(&RateLimitPolicyValidator{isLimitadorOperatorInstalled: isLimitadorOperatorInstalled}).Subscription().Reconcile,
 		},
 	}
 

diff --git a/controllers/ratelimit_policies_validator.go b/controllers/ratelimit_policies_validator.go
@@ -15,7 +15,9 @@ import (
 	kuadrant "github.com/kuadrant/kuadrant-operator/pkg/kuadrant"
 )
 
-type RateLimitPolicyValidator struct{}
+type RateLimitPolicyValidator struct {
+	isLimitadorOperatorInstalled bool
+}
 
 // RateLimitPolicyValidator subscribes to events with potential to flip the validity of rate limit policies
 func (r *RateLimitPolicyValidator) Subscription() controller.Subscription {
@@ -41,6 +43,10 @@ func (r *RateLimitPolicyValidator) Validate(ctx context.Context, _ []controller.
 	defer logger.V(1).Info("finished validating rate limit policies")
 
 	state.Store(StateRateLimitPolicyValid, lo.SliceToMap(policies, func(policy machinery.Policy) (string, error) {
+		if !r.isLimitadorOperatorInstalled {
+			return policy.GetLocator(), kuadrant.NewErrDependencyNotInstalled("Limitador Operator")
+		}
+
 		var err error
 		if len(policy.GetTargetRefs()) > 0 && len(topology.Targetables().Children(policy)) == 0 {
 			ref := policy.GetTargetRefs()[0]