-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v1beta2 as hub version #482
Conversation
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
Signed-off-by: Alex Snaps <[email protected]>
@guicassolato wdyt: should I add the controller changes to this PR? |
Other than me missing something, I think we should keep this PR as one individual change, and the controller one as another... I started and it'll be quite a big change in itself... With that in mind, marking this as ready for review |
Signed-off-by: Alex Snaps <[email protected]>
@alexsnaps, can you please run There are still a few RBAC manifests that should not be part of this change. |
Signed-off-by: Alex Snaps <[email protected]>
I think this is still not doing what you expect... I'm unsure what you are referencing here but I scratched all in |
Signed-off-by: Guilherme Cassolato <[email protected]>
install/rbac/role.yaml
Outdated
- apiGroups: | ||
- operator.authorino.kuadrant.io | ||
resources: | ||
- authorinos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pushing a commit. IDK how this ended up here. This particular permission belongs to Authorino Operator, not to Authorino.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as expected. Thanks, @alexsnaps!
Unsure whether we want to change the controller to use v1beta2 as part of this PR or a different one...
Partially fixes #479 - need to update the controller logic to use the new API