Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OPA to v0.64.1 (latest) #466

Merged
merged 2 commits into from
May 15, 2024
Merged

Bump OPA to v0.64.1 (latest) #466

merged 2 commits into from
May 15, 2024

Conversation

guicassolato
Copy link
Collaborator

Requires #465

@guicassolato guicassolato self-assigned this May 14, 2024
@guicassolato guicassolato requested a review from a team May 14, 2024 10:34
@guicassolato guicassolato added the dependencies Pull requests that update a dependency file label May 14, 2024
KevFan
KevFan previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although suprised github diff is still showing changes from #465 that has been merged and it's not suggesting a rebase 🤔

@guicassolato guicassolato dismissed KevFan’s stale review May 15, 2024 08:55

The merge-base changed after approval.

@guicassolato
Copy link
Collaborator Author

Looks good to me, although suprised github diff is still showing changes from #465 that has been merged and it's not suggesting a rebase 🤔

Weird indeed.

It also says:

The merge-base changed after approval.

which I don't remember having done.

@guicassolato guicassolato merged commit 798fadb into main May 15, 2024
12 checks passed
@guicassolato guicassolato deleted the bump-opa branch May 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevFan KevFan KevFan left review comments

Assignees

@guicassolato guicassolato

Labels
dependencies Pull requests that update a dependency file
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicassolato @KevFan