Tentative at dealing with no Response provided

Signed-off-by: Alex Snaps <[email protected]>
Kuadrant · Sep 4, 2024 · 6d46e21 · 6d46e21
1 parent 37ef7d1
commit 6d46e21
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/controllers/auth_config_controller.go b/controllers/auth_config_controller.go
@@ -472,27 +472,29 @@ func (r *AuthConfigReconciler) translateAuthConfig(ctx context.Context, authConf
 
 	interfacedResponseConfigs := make([]auth.AuthConfigEvaluator, 0)
 
-	for responseName, headerResponse := range authConfig.Spec.Response.Success.Headers {
-		translatedResponse := evaluators.NewResponseConfig(
-			responseName,
-			headerResponse.Priority,
-			buildJSONExpression(authConfig, headerResponse.Conditions, jsonexp.All),
-			"httpHeader",
-			headerResponse.Key,
-			headerResponse.Metrics,
-		)
+	if authConfig.Spec.Response != nil {
+		for responseName, headerResponse := range authConfig.Spec.Response.Success.Headers {
+			translatedResponse := evaluators.NewResponseConfig(
+				responseName,
+				headerResponse.Priority,
+				buildJSONExpression(authConfig, headerResponse.Conditions, jsonexp.All),
+				"httpHeader",
+				headerResponse.Key,
+				headerResponse.Metrics,
+			)
 
-		if headerResponse.Cache != nil {
-			ttl := headerResponse.Cache.TTL
-			if ttl == 0 {
-				ttl = api.EvaluatorDefaultCacheTTL
+			if headerResponse.Cache != nil {
+				ttl := headerResponse.Cache.TTL
+				if ttl == 0 {
+					ttl = api.EvaluatorDefaultCacheTTL
+				}
+				translatedResponse.Cache = evaluators.NewEvaluatorCache(
+					*getJsonFromStaticDynamic(&headerResponse.Cache.Key),
+					ttl,
+				)
 			}
-			translatedResponse.Cache = evaluators.NewEvaluatorCache(
-				*getJsonFromStaticDynamic(&headerResponse.Cache.Key),
-				ttl,
-			)
+			interfacedResponseConfigs = append(interfacedResponseConfigs, translatedResponse)
 		}
-		interfacedResponseConfigs = append(interfacedResponseConfigs, translatedResponse)
 	}
 
 	for responseName, response := range authConfig.Spec.Response.Success.DynamicMetadata {