Feature/58 aws options from appsettings #61
+405
−55
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| using Microsoft.Extensions.Configuration; | ||
|
|
||
| namespace Sample7 | ||
| { | ||
| class Program | ||
| { | ||
| static void Main(string[] args) | ||
| { | ||
| var builder = new ConfigurationBuilder(); | ||
|
|
||
| /* | ||
| * Add some configuration source. | ||
| * In this case, we're adding our appsettings JSON file. | ||
| */ | ||
| builder.AddJsonFile("appsettings.json"); | ||
|
|
||
| /* | ||
| * Add the secrets manager | ||
| */ | ||
| builder.AddSecretsManager(configurator: op => | ||
| { | ||
| /* | ||
| * Configure the secrets manager to read options | ||
| * from a certain config section | ||
| */ | ||
| op.ReadFromConfigSection("MySecretsManagerConfig"); | ||
|
|
||
| /* | ||
| * Can still use the other options here | ||
| */ | ||
| op.KeyGenerator = (entry, key) => key.ToUpper(); | ||
| }); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp3.1</TargetFramework> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="5.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Kralizek.Extensions.Configuration.AWSSecretsManager\Kralizek.Extensions.Configuration.AWSSecretsManager.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Update="appsettings.json"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "AWS": { | ||
| "Profile": "MyGeneralProfile", | ||
| "Region": "eu-west-2", | ||
| }, | ||
| "MySecretsManagerConfig": { | ||
| "Profile": "MySecretsProfile", | ||
| "Region": "eu-west-1", | ||
| "ProfilesLocation": "C:\\Users\\MyUser\\.aws\\", | ||
| "PollingIntervalInSeconds": 60, | ||
| "AcceptedSecretArns": [ | ||
| "arn:example:01-abcxyz", | ||
| "arn:example:02", | ||
| "unique-secret-name" | ||
| ], | ||
| "ListSecretsFilters": [ | ||
| { | ||
| "Key": "Name", | ||
| "Values": [ "Value1", "Value2" ] | ||
| } | ||
| ] | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| namespace Kralizek.Extensions.Configuration.Internal | ||
| { | ||
| /// <summary> | ||
| /// An object intended to bind an <see cref="IConfigurationSection"/> to. | ||
| /// </summary> | ||
| internal class AwsConfigSection | ||
| { | ||
| public const string DefaultConfigSectionName = "AWS"; | ||
|
|
||
| /// <summary> | ||
| /// The string representation of an AWS Region. | ||
| /// </summary> | ||
| public string Region { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The name of the credentials profile to be used by the Secrets Manager client. | ||
| /// </summary> | ||
| public string Profile { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The location of the file containing the credentials profiles. | ||
| /// </summary> | ||
| public string ProfilesLocation { get; set; } | ||
| } | ||
|
There was a problem hiding this comment. I've been thinking if it's better for the extension to handle everything or if it is worth taking a dependency on AWSSDK.Extensions.NETCore.Setup . Unfortunately Using AWSSDK.Extensions.NETCore.Setup will allow smooth integration with localstack through localstack-dotnet-client There was a problem hiding this comment. I'd like to keep this library as supple and lean as possible. |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather specify that many options can be specified using the Microsoft Configuration system without limiting to the JSON file. After all, the configuration values can be provided using other providers.